A by akama-aka · Pull Request #2 · akama-aka/phpmyadmin

akama-aka · 2023-10-31T21:17:10Z

Description

Please describe your pull request.

Fixes #

Before submitting pull request, please review the following checklist:

Make sure you have read our CONTRIBUTING.md document.
Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
Every commit has a descriptive commit message.
Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
Any new functionality is covered by tests.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Rename the directory `libraries/classes/` to `src/`

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

For random order seed 1693489393. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

This reverts commit b55e2ab. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Each page is a different page, so it makes more sense to do a full page reload instead of using AJAX to load the main content. This also avoid some possible issues with broken event handlers and not properly loaded pages. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev> (cherry picked from commit 36a77f7) Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Force a full page reload for top menu links (5.2)

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Fixed the exit exception for the /url path Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com> * Fixed the exit exception if in case the url is empty Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com> * Added new lines to pass linter checks --------- Signed-off-by: Sachin Bahukhandi <sachinb0013@gmail.com>

This test classes will fail if the Small attribute was used instead. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Optimize autocomplete

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Dependency injection should be used instead. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Adds a note to the $cfg['Servers'][$i]['nopassword'] directive to add a reference to the $cfg['Servers'][$i]['AllowNoPassword']. Fixes #18680. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Add a documentation note to the nopassword config

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

[ci skip] Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Refactor Results class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Currently translated at 70.2% (2392 of 3403 strings) [ci skip] Translation: phpMyAdmin/Development Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/sk/ Signed-off-by: Pavol Linet <linet.pavol@gmail.com>

Currently translated at 72.8% (2498 of 3427 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/sk/ Signed-off-by: Pavol Linet <linet.pavol@gmail.com>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Rename ./libraries directory to ./app

- Upgrading php-webdriver/webdriver (1.15.0 => 1.15.1) - Upgrading phpmyadmin/sql-parser (dev-master 46ff7ec => dev-master 08f465a) - Upgrading roave/security-advisories (dev-latest 26c07e7 => dev-latest 66671a6) - Upgrading symfony/cache (v6.3.5 => v6.3.6) - Upgrading symfony/var-exporter (v6.3.4 => v6.3.6) Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Update PHP dependencies

- Related to #18512 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Move ./js directory to ./resources/js

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Add ShellCheck to CI

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

[ci skip] Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>

Currently translated at 25.8% (878 of 3403 strings) [ci skip] Translation: phpMyAdmin/Development Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/ Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>

Currently translated at 27.1% (929 of 3427 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/ Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>

* Added new charset queries Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Improve collations support for MariaDB 10.10+ Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Using dbi to check for MariaDB Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Removed unnecessary query Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Cleanup Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Whitespaces Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Whitespaces Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Switched to getVersion() Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Removed use of version_compare Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Test for MariaDB 10.10+ Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Update test/classes/CharsetsTest.php Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev> --------- Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev> Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

* Added new charset queries Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Improve collations support for MariaDB 10.10+ Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Using dbi to check for MariaDB Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Removed unnecessary query Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Cleanup Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Whitespaces Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Whitespaces Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Switched to getVersion() Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Removed use of version_compare Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Test for MariaDB 10.10+ Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> * Update test/classes/CharsetsTest.php Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev> Fixes #18769 --------- Signed-off-by: Dmitrii Kustov <simbiat@outlook.com> Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev> Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev> (cherry picked from commit ef92f1f) Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Fixes #18769 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

- Upgrading laminas/laminas-diactoros (3.2.0 => 3.3.0) - Upgrading phpmyadmin/sql-parser (dev-master 08f465a => dev-master 9db9c53) - Upgrading phpstan/phpstan (1.10.39 => 1.10.40) - Upgrading phpstan/phpstan-strict-rules (1.5.1 => 1.5.2) - Upgrading phpunit/phpunit (10.4.1 => 10.4.2) - Upgrading roave/security-advisories (dev-latest 66671a6 => dev-latest d66cd3b) Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

MauricioFauth and others added 30 commits August 30, 2023 14:05

Fix Selenium\Database\OperationsTest failing test

c4fb42e

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Fix TableTest failing test

b526a29

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Merge branch 'QA_5_2'

bb2869b

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Rename the directory libraries/classes/ to src/

c2955cc

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Replace libraries/classes references with src

1ddcad2

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Merge pull request #18667 from MauricioFauth/skeleton

d1a29d4

Rename the directory `libraries/classes/` to `src/`

Use PHP 8.4 instead of nightly in the tests workflow

3f694de

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Add windows-latest to tests workflow

b55e2ab

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Fix ServerRequestFactoryTest failing test

91e4b01

For random order seed 1693489393. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Fix mutation-tests workflow

6012fd2

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Revert "Add windows-latest to tests workflow"

38ebd94

This reverts commit b55e2ab. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Merge pull request #18675 from MauricioFauth/fix-17404

a07802e

Force a full page reload for top menu links (5.2)

Merge branch 'QA_5_2'

8bb3aeb

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Fix UtilTest::testLocalisedDate() with missing locale

6b3e076

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Fix infection.json5.dist source directory

ed0fa0d

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Add Medium attribute to some test classes

7cace99

This test classes will fail if the Small attribute was used instead. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Optimize autocomplete

8cf36be

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Merge pull request #18678 from kamil-tekiela/Optimize-autocomplete

a483c79

Optimize autocomplete

Optimize ChangeController

c4bd8d9

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Improve param types in ColumnsDefinition

fa45763

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Refactor getSqlTemplateAndRequiredFields()

81e9c90

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Refactor expandUserString()

8c260bc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Refactor getColumn and getColumns

ed59318

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Deprecate Config::getInstance() method

f7a82ce

Dependency injection should be used instead. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Remove ExitException from AbstractController::checkParameters()

ae7f509

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Add a documentation note to the nopassword config

53d3aae

Adds a note to the $cfg['Servers'][$i]['nopassword'] directive to add a reference to the $cfg['Servers'][$i]['AllowNoPassword']. Fixes #18680. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Merge pull request #18685 from MauricioFauth/nopassword-config-doc-note

98ab471

Add a documentation note to the nopassword config

Merge branch 'QA_5_2'

1b2da96

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

kamil-tekiela and others added 29 commits October 21, 2023 19:46

Remove $properties

d3b1714

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Remove 1st param in getUniqueCondition()

b230b1a

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Create UniqueCondition class

2e81a80

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Update po files

a3e2117

[ci skip] Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>

Apply suggestions from code review

461655f

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Merge pull request #18774 from kamil-tekiela/Display-Results-class

4342b42

Refactor Results class

Fix unneeded consts in UtilTest

a02223f

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Translated using Weblate (Slovak)

28bae97

Currently translated at 70.2% (2392 of 3403 strings) [ci skip] Translation: phpMyAdmin/Development Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/sk/ Signed-off-by: Pavol Linet <linet.pavol@gmail.com>

Translated using Weblate (Slovak)

93143c4

Currently translated at 72.8% (2498 of 3427 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/sk/ Signed-off-by: Pavol Linet <linet.pavol@gmail.com>

Rename ./libraries directory to ./app

87c494f

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Move ./cache directory to ./app/cache

941c795

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Merge pull request #18778 from MauricioFauth/app-dir

7036da2

Rename ./libraries directory to ./app

Merge pull request #18779 from MauricioFauth/composer-update

36a22cb

Update PHP dependencies

Move ./js directory to ./resources/js

d888c29

- Related to #18512 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Merge pull request #18780 from MauricioFauth/js-dir

98b7f38

Move ./js directory to ./resources/js

Add shellcheck to CI

5d6d2f5

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Fix issues reported by shellcheck

cd883c6

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Merge pull request #18781 from MauricioFauth/shellcheck-action

8d982e3

Add ShellCheck to CI

Remove motranslator functions file from composer.json

5379d44

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Update po files

cbfb41c

[ci skip] Signed-off-by: phpMyAdmin bot <bot@phpmyadmin.net>

Translated using Weblate (Macedonian)

270a40f

Currently translated at 25.8% (878 of 3403 strings) [ci skip] Translation: phpMyAdmin/Development Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/mk/ Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>

Translated using Weblate (Macedonian)

437d751

Currently translated at 27.1% (929 of 3427 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/ Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com>

Merge branch 'QA_5_2'

115160e

Fixes #18769 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Update JavaScript dependencies

00ac9e5

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

Merge branch 'QA_5_2'

5dce8f1

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>

akama-aka merged commit ae81b00 into akama-aka:master Oct 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A#2

A#2
akama-aka merged 537 commits intoakama-aka:masterfrom
phpmyadmin:master

akama-aka commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Conversation

akama-aka commented Oct 31, 2023

Description

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants